linux-kernel - [PATCH -next] serial: etraxfs-uart: Update gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 13:34:52 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-cris-kernel@...s.com,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: [PATCH -next] serial: etraxfs-uart: Update gpiod API

Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
makes the flags argument to devm_gpiod_get_optional mandatory but does not
update all users. This results in the following build error.

drivers/tty/serial/etraxfs-uart.c:933:16: error:
	too few arguments to function ‘devm_gpiod_get_optional’

Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
 drivers/tty/serial/etraxfs-uart.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c
index a57301a6fe42..e35a19b214d5 100644
--- a/drivers/tty/serial/etraxfs-uart.c
+++ b/drivers/tty/serial/etraxfs-uart.c
@@ -930,10 +930,10 @@ static int etraxfs_uart_probe(struct platform_device *pdev)
 
 	up->irq = irq_of_parse_and_map(np, 0);
 	up->regi_ser = of_iomap(np, 0);
-	up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr");
-	up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr");
-	up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri");
-	up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd");
+	up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr", GPIOD_ASIS);
+	up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr", GPIOD_ASIS);
+	up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri", GPIOD_ASIS);
+	up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd", GPIOD_ASIS);
 	up->port.dev = &pdev->dev;
 	cris_serial_port_init(&up->port, dev_id);
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/