linux-kernel - Re: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuKMvTmwkPdVB4-6-sr1ErZ6FUzc+_UEvhz=Nq3Na=N5NA@mail.gmail.com>
Date:	Tue, 21 Jul 2015 14:50:49 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list()

On Tue, Jul 21, 2015 at 2:45 PM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>

Looks good, thanks!

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bf4bd1d..adb03c6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
>   */
>  static int gpiochip_add_to_list(struct gpio_chip *chip)
>  {
> -       struct list_head *pos = &gpio_chips;
> +       struct list_head *pos;
>         struct gpio_chip *_chip;
>         int err = 0;
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/