linux-kernel - Re: [RFC v3 2/2] firmware: add firmware signature checking support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB=NE6WpVnSD98CQ86ccnziwCuP5cfMDqY++1GWc7Ypv0hkH6A@mail.gmail.com>
Date:	Tue, 21 Jul 2015 16:14:02 -0700
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Kees Cook <keescook@...omium.org>,
	David Howells <dhowells@...hat.com>
Cc:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	Ming Lei <ming.lei@...onical.com>,
	Seth Forshee <seth.forshee@...onical.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Paul Bolle <pebolle@...cali.nl>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>, jlee@...e.com,
	Takashi Iwai <tiwai@...e.de>,
	Casey Schaufler <casey@...aufler-ca.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kyle McMartin <kyle@...nel.org>,
	David Woodhouse <David.Woodhouse@...el.com>
Subject: Re: [RFC v3 2/2] firmware: add firmware signature checking support

On Tue, Jul 14, 2015 at 12:20 PM, Luis R. Rodriguez <mcgrof@...e.com> wrote:
>> > +       strcpy(signed_name, buf->fw_id);
>> > +       strncat(signed_name, sign_ext, strlen(sign_ext));
>>
>> fw_id is potentially unbounded, so using strncat hear poses an
>> overflow risk. Maybe better to use strlcpy?
>>
>
> Thanks for the feedback, indeed.

Ok I've made this change based on David's tree.

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/