linux-kernel - Re: [PATCH -mm v9 2/8] hwpoison: use page_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150721163412.1b44e77f5ac3b742734d1ce6@linux-foundation.org>
Date:	Tue, 21 Jul 2015 16:34:12 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	Andres Lagar-Cavilla <andreslc@...gle.com>,
	Minchan Kim <minchan@...nel.org>,
	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	Greg Thelen <gthelen@...gle.com>,
	Michel Lespinasse <walken@...gle.com>,
	David Rientjes <rientjes@...gle.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Jonathan Corbet <corbet@....net>, <linux-api@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-mm@...ck.org>,
	<cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm v9 2/8] hwpoison: use page_cgroup_ino for filtering
 by memcg

On Sun, 19 Jul 2015 15:31:11 +0300 Vladimir Davydov <vdavydov@...allels.com> wrote:

> Hwpoison allows to filter pages by memory cgroup ino. Currently, it
> calls try_get_mem_cgroup_from_page to obtain the cgroup from a page and
> then its ino using cgroup_ino, but now we have an apter method for that,
> page_cgroup_ino, so use it instead.

I assume "an apter" was supposed to be "a helper"?

> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -45,12 +45,9 @@ static int hwpoison_inject(void *data, u64 val)
>  	/*
>  	 * do a racy check with elevated page count, to make sure PG_hwpoison
>  	 * will only be set for the targeted owner (or on a free page).
> -	 * We temporarily take page lock for try_get_mem_cgroup_from_page().
>  	 * memory_failure() will redo the check reliably inside page lock.
>  	 */
> -	lock_page(hpage);
>  	err = hwpoison_filter(hpage);
> -	unlock_page(hpage);
>  	if (err)
>  		goto put_out;
>  
> @@ -126,7 +123,7 @@ static int pfn_inject_init(void)
>  	if (!dentry)
>  		goto fail;
>  
> -#ifdef CONFIG_MEMCG_SWAP
> +#ifdef CONFIG_MEMCG
>  	dentry = debugfs_create_u64("corrupt-filter-memcg", 0600,
>  				    hwpoison_dir, &hwpoison_filter_memcg);
>  	if (!dentry)

Confused.  We're changing the conditions under which this debugfs file
is created.  Is this a typo or some unchangelogged thing or what?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/