linux-kernel - Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2015 08:26:36 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Stefan Wahren <stefan.wahren@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org
CC:	wxt@...k-chips.com, linux-api@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>, sboyd@...eaurora.org,
	arnd@...db.de, s.hauer@...gutronix.de,
	linux-kernel@...r.kernel.org, mporter@...sulko.com,
	linux-arm-msm@...r.kernel.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	pantelis.antoniou@...sulko.com, Mark Brown <broonie@...nel.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

Thanks Stefan,

On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.

--srini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/