linux-kernel - Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507220937350.18576@nanos>
Date:	Wed, 22 Jul 2015 09:57:56 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Hanjun Guo <hanjun.guo@...aro.org>
cc:	Marc Zyngier <marc.zyngier@....com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Jason Cooper <jason@...edaemon.net>,
	linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Subject: Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node
 field

BOn Wed, 22 Jul 2015, Hanjun Guo wrote:

> On 07/21/2015 06:07 PM, Marc Zyngier wrote:
> > The struct irq_domain contains a "struct device_node *" field
> > (of_node) that is almost the only link between the irqdomain
> > and the device tree infrastructure.
> > 
>1;2802;0c > In order to prepare for the removal of that field, convert all
> > users outside of kernel/irq/irqdomain.c to use an accessor.
> > 
> > Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> > ---
> >   arch/mips/cavium-octeon/octeon-irq.c          | 4 ++--
> >   arch/powerpc/platforms/cell/axon_msi.c        | 2 +-
> >   arch/powerpc/platforms/cell/spider-pic.c      | 9 ++++++---
> >   arch/powerpc/platforms/powernv/opal-irqchip.c | 2 +-
> >   arch/powerpc/sysdev/ehv_pic.c                 | 3 ++-
> >   arch/powerpc/sysdev/fsl_msi.c                 | 2 +-
> >   arch/powerpc/sysdev/i8259.c                   | 3 ++-
> >   arch/powerpc/sysdev/ipic.c                    | 3 ++-
> >   arch/powerpc/sysdev/mpic.c                    | 3 ++-
> >   arch/powerpc/sysdev/mpic_msi.c                | 2 +-
> >   arch/powerpc/sysdev/qe_lib/qe_ic.c            | 3 ++-
> >   drivers/gpio/gpio-sodaville.c                 | 2 +-
> >   drivers/irqchip/exynos-combiner.c             | 2 +-
> >   drivers/irqchip/irq-atmel-aic-common.c        | 2 +-
> >   drivers/irqchip/irq-crossbar.c                | 4 ++--
> >   drivers/irqchip/irq-gic-v2m.c                 | 2 +-
> >   drivers/irqchip/irq-gic-v3-its.c              | 2 +-
> >   drivers/irqchip/irq-gic-v3.c                  | 2 +-
> >   drivers/irqchip/irq-gic.c                     | 2 +-
> >   drivers/irqchip/irq-hip04.c                   | 2 +-
> >   drivers/irqchip/irq-mtk-sysirq.c              | 2 +-
> >   drivers/irqchip/irq-s3c24xx.c                 | 4 ++--
> >   drivers/irqchip/irq-tegra.c                   | 4 ++--
> >   drivers/irqchip/irq-vf610-mscm-ir.c           | 5 +++--
> >   drivers/spmi/spmi-pmic-arb.c                  | 2 +-
> >   include/linux/irqdomain.h                     | 5 +++++
> >   26 files changed, 46 insertions(+), 32 deletions(-)
> 
> It seems to me that some other files missed,
> in arch/powerpc/platforms/pasemi/msi.c:
> 
>         if (!mpic->irqhost->of_node ||
>             !of_device_is_compatible(mpic->irqhost->of_node,
>                                      "pasemi,pwrficient-openpic"))
>                 return -ENODEV;
> 
> If you need more eyes to find all of them, please count me in :)

The proper tool to find them is coccinelle, not eyes.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/