| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150722004124.GE15042@codeaurora.org> Date: Tue, 21 Jul 2015 17:41:24 -0700 From: Stephen Boyd <sboyd@...eaurora.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: linux-kernel@...r.kernel.org, heikki.krogerus@...ux.intel.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heiko Stuebner <heiko@...ech.de>, linux-clk@...r.kernel.org Subject: Re: [PATCH v4 3/6] clk: fractional-divider: keep mwidth and nwidth internally On 07/14, Andy Shevchenko wrote: > diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c > index 7cfcc56..16f42ae 100644 > --- a/drivers/clk/clk-fractional-divider.c > +++ b/drivers/clk/clk-fractional-divider.c > @@ -128,9 +128,11 @@ struct clk *clk_register_fractional_divider(struct device *dev, > > fd->reg = reg; > fd->mshift = mshift; > - fd->mmask = (BIT(mwidth) - 1) << mshift; > + fd->mwidth = mwidth; > + fd->mmask = GENMASK(mwidth - 1, 0) << mshift; > fd->nshift = nshift; > - fd->nmask = (BIT(nwidth) - 1) << nshift; > + fd->nwidth = nwidth; > + fd->nmask = GENMASK(nwidth - 1, 0) << nshift; Please do the shifts in the GENMASK. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists