linux-kernel - RE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295AA03106@G9W0745.americas.hpqcorp.net>
Date:	Wed, 22 Jul 2015 14:38:28 +0000
From:	"Elliott, Robert (Server Storage)" <Elliott@...com>
To:	Pan Xinhui <xinhuix.pan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"bp@...e.de" <bp@...e.de>, "Kani, Toshimitsu" <toshi.kani@...com>,
	"jgross@...e.com" <jgross@...e.com>,
	"mcgrof@...e.com" <mcgrof@...e.com>,
	"mnipxh@....com" <mnipxh@....com>,
	"yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>,
	"Borislav Petkov" <bp@...en8.de>
Subject: RE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in
 reserve_memtype



---
Robert Elliott, HP Server Storage

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Pan Xinhui
> Sent: Wednesday, July 22, 2015 8:27 AM
...
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index 188e3e0..8fa1f07 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -521,10 +521,7 @@ int reserve_memtype(u64 start, u64 end, enum
> page_cache_mode req_type,
> 
>  	is_range_ram = pat_pagerange_is_ram(start, end);
>  	if (is_range_ram == 1) {
> -
> -		err = reserve_ram_pages_type(start, end, req_type, new_type);
> -
> -		return err;
> +		return reserve_ram_pages_type(start, end, req_type, new_type);
>  	} else if (is_range_ram < 0) {
>  		return -EINVAL;
>  	}

With each branch now just one line, the {} can be removed.