[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1437576174.30329.84.camel@mtksdaap41>
Date: Wed, 22 Jul 2015 22:42:54 +0800
From: Henry Chen <HenryC.Chen@...iatek.com>
To: Javier Martinez Canillas <javier@...hile0.org>
CC: Mark Brown <broonie@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Liam Girdwood <lgirdwood@...il.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>,
"Sascha Hauer" <kernel@...gutronix.de>,
Matthias Brugger <matthias.bgg@...il.com>,
<eddie.huang@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] regulator: mt6311: Add support for mt6311
regulator
On Wed, 2015-07-22 at 14:50 +0200, Javier Martinez Canillas wrote:
> > +
> > +struct mt6311 {
> > + struct device *dev;
> > + struct regmap *regmap;
> > + struct regulator_dev *rdev[MT6311_MAX_REGULATORS];
> > + int num_regulator;
> > + int chip_cid;
> > +};
>
> It seems this struct can be removed, the rdev, num_regulator and
> chip_cid fields are set but not used and dev and regmap are only used
> to set the struct regulator_config fields in mt6311_regulator_init().
> But that won't be necessary if you just remove the
> mt6311_regulator_init() function and move the regulator registration
> logic to mt6311_i2c_probe().
Yes, it should be removed, thanks for the advise.
Henry
>
> Best regards,
> Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists