linux-kernel - Re: [PATCH 1/4] RTC: fix double free in rtc_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150722203259.GL2853@piout.net>
Date:	Wed, 22 Jul 2015 22:32:59 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	Vasiliy Kulikov <segooon@...il.com>
Subject: Re: [PATCH 1/4] RTC: fix double free in rtc_register_device() error
 path

On 20/07/2015 at 16:02:49 -0700, Dmitry Torokhov wrote :
> Commit 59cca865f21e9e7beab73fcf79ba4eb776a4c228 correctly noted that naked
> kfree() should not be used after failed device_register() call, however,
> while it added the needed put_device() it forgot to remove the original
> kfree() causing double-free.
> 
> Cc: Vasiliy Kulikov <segooon@...il.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/rtc/class.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
Applied after fixing the commit description in the commit log, thanks.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/