lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Jul 2015 23:50:35 +0200 (CEST) From: Jiri Kosina <jkosina@...e.com> To: Pavel Machek <pavel@....cz> cc: Vlastimil Babka <vbabka@...e.cz>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Samuel Thibault <samuel.thibault@...-lyon.org>, Pali Rohár <pali.rohar@...il.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, rpurdie@...ys.net, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs On Wed, 22 Jul 2015, Pavel Machek wrote: > > I am however not sure whether input_leds_connect() is not too unkind to > > unnamed LEDs and shouldn't be more tolerant to those in the long term. > > Maybe. > > > From: Jiri Kosina <jkosina@...e.com> > > Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs > > > > input_leds_connect() is skipping registration of LEDs for which > > there is no symbolic name in input_led_info[]. > > Yes, and rather than testing for "no name" special case at two places, > what about simply giving up when we see such error? Well, that's quite the oposite of the "be more tolerant" aproach proposed above :) I don't see a reason why the sole fact that the device has at least one LED that kernel can't handle properly should mean that neither of the other LEDs will work. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists