linux-kernel - Re: [PATCH] extcon: Drop owner assignment from i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <55B05409.7010805@samsung.com>
Date:	Thu, 23 Jul 2015 11:40:09 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	"open list:EXTERNAL CONNECTOR SUBSYSTEM (EXTCON)" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] extcon: Drop owner assignment from i2c_driver

On 07/10/2015 02:50 PM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/extcon/extcon-rt8973a.c | 1 -
>  drivers/extcon/extcon-sm5502.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c
> index 92c939221a41..11592e980bc1 100644
> --- a/drivers/extcon/extcon-rt8973a.c
> +++ b/drivers/extcon/extcon-rt8973a.c
> @@ -693,7 +693,6 @@ MODULE_DEVICE_TABLE(i2c, rt8973a_i2c_id);
>  static struct i2c_driver rt8973a_muic_i2c_driver = {
>  	.driver		= {
>  		.name	= "rt8973a",
> -		.owner	= THIS_MODULE,
>  		.pm	= &rt8973a_muic_pm_ops,
>  		.of_match_table = rt8973a_dt_match,
>  	},
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 817dece23b4c..0ffefefa2e26 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -685,7 +685,6 @@ MODULE_DEVICE_TABLE(i2c, sm5502_i2c_id);
>  static struct i2c_driver sm5502_muic_i2c_driver = {
>  	.driver		= {
>  		.name	= "sm5502",
> -		.owner	= THIS_MODULE,
>  		.pm	= &sm5502_muic_pm_ops,
>  		.of_match_table = sm5502_dt_match,
>  	},
> 

Applied it.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/