linux-kernel - Re: [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B083C6.503@linux.intel.com>
Date:	Thu, 23 Jul 2015 14:03:50 +0800
From:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
CC:	gleb@...nel.org, mtosatti@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, alex.williamson@...hat.com,
	bsd@...hat.com, lersek@...hat.com, jordan.l.justen@...el.com,
	edk2-devel@...ts.sourceforge.net,
	Xiao Guangrong <guangrong.xiao@...el.com>
Subject: Re: [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache
 is disabled



On 07/23/2015 01:56 PM, Paolo Bonzini wrote:
>
>
> On 15/07/2015 21:25, Xiao Guangrong wrote:
>> From: Xiao Guangrong <guangrong.xiao@...el.com>
>>
>> Current firmware depends on WB to fast boot, please refer to
>>        https://lkml.org/lkml/2015/7/12/115
>>
>> Let's us WB if CR0.CD is set to make this kind of firmware happy
>>
>> This quirk can be dropped by using KVM_ENABLE_CAP API with
>> KVM_CAP_DISABLE_QUIRKS if the broken firmware is gone
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@...el.com>
>
> Your patch is actually *enabling* the quirk if KVM_QUIRK_CD_AS_WB is
> included in the disabled quirks.  I'm squashing in this change:

Yep, i misunderstood the meaning of "disabled-quirks", thanks for your
nice adjustment, Paolo!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/