linux-kernel - Re: [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B0ACE6.2080805@citrix.com>
Date:	Thu, 23 Jul 2015 10:59:18 +0200
From:	Roger Pau Monné <roger.pau@...rix.com>
To:	Bob Liu <bob.liu@...cle.com>, <xen-devel@...ts.xenproject.org>
CC:	<david.vrabel@...rix.com>, <linux-kernel@...r.kernel.org>,
	<konrad.wilk@...cle.com>
Subject: Re: [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list
 when !feature_persistent

El 22/07/15 a les 8.40, Bob Liu ha escrit:
> We should consider info->feature_persistent when adding indriect page to list
                                                          ^ indirect
> info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered.
> 
> Signed-off-by: Bob Liu <bob.liu@...cle.com>

Thanks, this looks correct indeed. If we are using persistent grants the
indirect_pages list should always be empty because blkfront has
pre-allocated enough persistent pages to fill all requests on the ring.

Acked-by: Roger Pau Monné <roger.pau@...rix.com>

Should be backported to stable branches.

Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/