linux-kernel - Re: [PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B0B738.1050603@hitachi.com>
Date:	Thu, 23 Jul 2015 18:43:20 +0900
From:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Vivek Goyal <vgoyal@...hat.com>, linux-doc@...r.kernel.org,
	x86@...nel.org, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on
 NMI

(2015/07/23 17:15), Peter Zijlstra wrote:
> On Wed, Jul 22, 2015 at 11:14:21AM +0900, Hidehiro Kawai wrote:
>> +DEFINE_SPINLOCK(panic_lock);
> 
> At the very least this should be a raw spinlock, but wth aren't you
> using a simple atomic_xchg() ?

Thanks for the comment.

I just followed the current panic_lock implementation.
Using atomic_xchg() may be OK.  I'll try another version
with atomic_xchg().

Regards,
-- 
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/