linux-kernel - Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150723094651.GA15301@infradead.org>
Date:	Thu, 23 Jul 2015 02:46:51 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Spencer Baugh <sbaugh@...ern.com>
Cc:	"supporter:QLOGIC QLA2XXX FC-SCSI DRIVER" 
	<qla2xxx-upstream@...gic.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"open list:QLOGIC QLA2XXX FC-SCSI DRIVER" 
	<linux-scsi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Joern Engel <joern@...estorage.com>,
	Spencer Baugh <Spencer.baugh@...estorage.com>,
	Dilip Kumar Uppugandla <dilip@...estorage.com>,
	target-devel@...r.kernel.org,
	Bart Van Assche <bart.vanassche@...disk.com>
Subject: Re: [PATCH] qla2xxx: Return the fabric command state for non-task
 management requests

On Tue, Jul 21, 2015 at 03:07:55PM -0700, Spencer Baugh wrote:
> From: Dilip Kumar Uppugandla <dilip@...estorage.com>
> 
> Invoking get_cmd_state for qla2xxx always returns 0. Instead change it
> to return the actual fabric state from qla_tgt_cmd. This will help with
> debugging.

I think the ->get_cmd_state callback should go away instead.  Returning
values with zero meaning to the core in a callback doesn't make much
sense.  I'd rather build some real structured debugging infrastructure,
so it would be useful if you could explain the use case for this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/