linux-kernel - Re: [PATCH] mm/Kconfig: NEED_BOUNCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150723134714.GA29224@quack.suse.cz>
Date:	Thu, 23 Jul 2015 15:47:14 +0200
From:	Jan Kara <jack@...e.cz>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	akpm@...ux-foundation.org, jack@...e.cz, minchan@...nel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	pebolle@...cali.nl, stefan.hengelein@....de
Subject: Re: [PATCH] mm/Kconfig: NEED_BOUNCE_POOL: clean-up condition

On Thu 23-07-15 13:18:06, Valentin Rothberg wrote:
> commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3
> and JBD, hence remove the superfluous condition.
> 
> Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
> ---
> I detected the issue with undertaker-checkpatch
> (https://undertaker.cs.fau.de)

Thanks. I have added your patch into my tree. BTW, is the checker automated
enough that it could be made part of the 0-day tests Fengguang runs?

								Honza
 
>  mm/Kconfig | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e79de2bd12cd..d4e6495a720f 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -299,15 +299,9 @@ config BOUNCE
>  # On the 'tile' arch, USB OHCI needs the bounce pool since tilegx will often
>  # have more than 4GB of memory, but we don't currently use the IOTLB to present
>  # a 32-bit address to OHCI.  So we need to use a bounce pool instead.
> -#
> -# We also use the bounce pool to provide stable page writes for jbd.  jbd
> -# initiates buffer writeback without locking the page or setting PG_writeback,
> -# and fixing that behavior (a second time; jbd2 doesn't have this problem) is
> -# a major rework effort.  Instead, use the bounce buffer to snapshot pages
> -# (until jbd goes away).  The only jbd user is ext3.
>  config NEED_BOUNCE_POOL
>  	bool
> -	default y if (TILE && USB_OHCI_HCD) || (BLK_DEV_INTEGRITY && JBD)
> +	default y if TILE && USB_OHCI_HCD
>  
>  config NR_QUICK
>  	int
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/