linux-kernel - Re: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150723135842.GG2531@xsjsorenbubuntu>
Date:	Thu, 23 Jul 2015 06:58:42 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Suneel Garapati <suneel.garapati@...inx.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...r.kernel.org>,
	<michals@...inx.com>, <sorenb@...inx.com>,
	<devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi

Hi Suneel,

On Thu, 2015-07-23 at 04:22PM +0530, Suneel Garapati wrote:
> adds rtc controller node to zynqmp devicetree.
> 
> Signed-off-by: Suneel Garapati <suneel.garapati@...inx.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 4 ++++
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi      | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> index 0a3f40e..b48ce47 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> @@ -45,3 +45,7 @@
>  &uart0 {
> 	status = "okay";
>  };
> +
> +&rtc {
> +	status = "okay";
> +};
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 11e0b00..b76ede1 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -220,6 +220,15 @@
> 			#size-cells = <0>;
> 		};
> 
> +		rtc: rtc@...60000 {
> +			compatible = "xlnx,zynqmp-rtc";
> +			status = "disabled";

do we need the status disabled here?

> +			reg = <0x0 0xffa60000 0x100>;
> +			interrupt-parent = <&gic>;
> +			interrupts = <0 26 4>, <0 27 4>;
> +			interrupt-names = "alm", "sec";

Descriptive names would be nice. What is 'alm' supposed to mean?

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/