linux-kernel - Re: Fix one source file coding sytle issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jul 2015 16:45:21 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	"Incarnation P. Lee" <incarnation.p.lee@...look.com>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	Greg KH <gregkh@...uxfoundation.org>,
	Julia Lawall <Julia.Lawall@...6.fr>, HPDD-discuss@...ts.01.org,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Fix one source file coding sytle issue.

Hi,

On Thu, Jul 23, 2015 at 8:20 AM, Incarnation P. Lee
<incarnation.p.lee@...look.com> wrote:
> drivers/staging/lustre/lustre/obdclass/cl_page.c

It is custom that you write slightly more introductory text here. Just
a file name is pointless.

The subject should probably contain [PATCH 0/5]. This would be
automatically fixed for you when using 'git format-patch
--cover-letter ...'.

The other patches should at least mention the area of the kernel the
change is done in:

  [PATCH N/5] staging: lustre: fix a missing space after comma

So that it becomes immediately clear where the change is done, and
what it is supposed to achieve.


> Signed-off-by: Incarnation P. Lee <incarnation.p.lee@...look.com>

That's not necessary in the cover letter.

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/