linux-kernel - Re: [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo5DgUMB4FYrjLXnLf8KFx-KPpd_bCnogSv_nsADuV0tjA@mail.gmail.com>
Date:	Thu, 23 Jul 2015 10:36:54 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Marc Zyngier <marc.zyngier@....com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Jason Cooper <jason@...edaemon.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yijing Wang <wangyijing@...wei.com>,
	Ma Jun <majun258@...wei.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Duc Dang <dhdang@....com>
Subject: Re: [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field

On Thu, Jul 23, 2015 at 9:52 AM, Marc Zyngier <marc.zyngier@....com> wrote:
> On 23/07/15 14:06, Bjorn Helgaas wrote:
>> On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote:
>>> In order to be able to populate the device msi_domain field,
>>> add the necessary hooks to propagate the host bridge msi_domain
>>> across secondary busses to devices.
>>>
>>> So far, nobody populates the initial msi_domain.
>>>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>>
>>> +static void pci_set_msi_domain(struct pci_dev *dev)
>>> +{
>>> +    /*
>>> +     * If no domain has been set through the pcibios callback,
>>> +     * inherit the default from the bus device.
>>
>> Nit: there isn't a pcibios callback anymore.
>
> There is actually one, in pci_add_device:
>
>         [...]
>         ret = pcibios_add_device(dev);
>         WARN_ON(ret < 0);
>
>         /* Setup MSI irq domain */
>         pci_set_msi_domain(dev);
>         [...]
>
> pcibios_add_device is the one I was referring to. I'll clarify the comment.

Oh, right!  I thought you were referring to
pcibios_set_host_bridge_msi_domain(), which got removed, but of course
that wouldn't even make sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/