lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jul 2015 09:57:14 +0800 From: xiakaixu <xiakaixu@...wei.com> To: Alexei Starovoitov <ast@...mgrid.com> CC: <davem@...emloft.net>, <acme@...nel.org>, <mingo@...hat.com>, <a.p.zijlstra@...llo.nl>, <masami.hiramatsu.pt@...achi.com>, <jolsa@...nel.org>, <wangnan0@...wei.com>, <linux-kernel@...r.kernel.org>, <pi3orama@....com>, <hekuang@...wei.com> Subject: Re: [PATCH v3 2/3] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter δΊ 2015/7/24 6:56, Alexei Starovoitov ει: > On 7/23/15 2:42 AM, Kaixu Xia wrote: >> According to the perf_event_map_fd and index, the function >> bpf_perf_event_read() can convert the corresponding map >> value to the pointer to struct perf_event and return the >> Hardware PMU counter value. >> >> Signed-off-by: Kaixu Xia <xiakaixu@...wei.com> > ... >> +static u64 bpf_perf_event_read(u64 r1, u64 index, u64 r3, u64 r4, u64 r5) >> +{ >> + struct bpf_map *map = (struct bpf_map *) (unsigned long) r1; >> + struct bpf_array *array = container_of(map, struct bpf_array, map); >> + struct perf_event *event; >> + >> + if (index >= array->map.max_entries) >> + return -E2BIG; >> + >> + event = array->events[index]; >> + if (!event) >> + return -EBADF; > > probably ENOENT makes more sense here. > >> + >> + if (event->state != PERF_EVENT_STATE_ACTIVE) >> + return -ENOENT; > > and -EINVAL here? Yeah, the errno is better. Thanks! > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists