linux-kernel - Re: [PATCH v6 0/3] Add MediaTek display PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jul 2015 17:10:58 +0800
From:	YH Huang <yh.huang@...iatek.com>
To:	Matthias Brugger <matthias.bgg@...il.com>
CC:	Mark Rutland <mark.rutland@....com>,
	Thierry Reding <thierry.reding@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>, <linux-pwm@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<srv_heupstream@...iatek.com>,
	<linux-mediatek@...ts.infradead.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	<yingjoe.chen@...iatek.com>, <yh.huang@...iatek.com>
Subject: Re: [PATCH v6 0/3] Add MediaTek display PWM driver

On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote:
> On Monday, July 20, 2015 04:17:14 PM YH Huang wrote:
> > This patch series add the use of display PWM driver, documentation
> > and device tree for Mediatek SoCs. The driver is used to support
> > the backlight of the panel. This is based on v4.2-rc1.
> > 
> > The clock definitions (CLK_MM_DISP_PWM*) are added by James Liao's patch:
> > clk: mediatek: Add subsystem clocks of MT8173
> > 
> > Change in v6:
> > 1. Enable clocks in the pwm_enable function
> > 2. Remove suspend/resume code since pwm-backlight driver has done the same
> > things 3. Revise some code to make it easier to read
> > 
> 
> Can you please provide the whole change log for all versions the next time.
> It's easier this way to understand the evolution of the series.

Change in v6:
1. Enable clocks in the pwm_enable function.
2. Remove suspend/resume code since pwm-backlight driver has done the
same things.
3. Revise some code to make it easier to read.

Change in v5:
1. Configure PWM output via pinctrl.
2. Fix the parameter name in dtsi.

Change in v4:
1. Codebase is on v4.2-rc1.
2. Add the PWM node in dtsi.
3. Change the dependency in Kconfig.
4. Rewrite some code for readability.

Change in v3:
1. Add suspend/resume function.
2. Fix the formula for high_width calculation.
3. Rewrite some code to make it easier to read.
4. Add more information in the commit message.

Change in v2:
1. Rewrite descriptions for driver in kconfig to make it much clear.
2. Rename the driver from "pwm-mediatek-disp" to "pwm-mtk-disp".
3. Disable clocks in the error path.
4. Change the shift values in decimal instead of hex.
5. Rename and add some variables or function name for consistency and
readability.
6. Drop unnecessary parentheses, spaces, variables and add newlines to
make the code easiler to read.

Thanks for your suggestion.

Regards,
YH Huang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/