lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jul 2015 13:13:24 +0200 From: Bastien Nocera <hadess@...ess.net> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] Input: goodix - Fix touch coords on WinBook TW100 and TW700 On Thu, 2015-07-23 at 14:56 -0700, Dmitry Torokhov wrote: > Hi Bastien, > > On Thu, Jul 23, 2015 at 04:13:28PM +0200, Bastien Nocera wrote: > > The touchscreen on the WinBook TW100 and TW700 don't match the > > default > > display, with 0,0 touches being reported when touching at the > > bottom > > right of the screen. > > > > 1280,800 0,800 > > +-------------+ > > | | > > | | > > | | > > +-------------+ > > 1280,0 0,0 > > > > It's unfortunately impossible to detect this problem with data from > > the > > DSDT, or other auxiliary metadata, so fallback to quirking this > > specific > > model of tablet instead. > > > > Signed-off-by: Bastien Nocera <hadess@...ess.net> > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> > > --- > > drivers/input/touchscreen/goodix.c | 31 > > +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/drivers/input/touchscreen/goodix.c > > b/drivers/input/touchscreen/goodix.c > > index b4d12e2..3722806 100644 > > --- a/drivers/input/touchscreen/goodix.c > > +++ b/drivers/input/touchscreen/goodix.c > > @@ -15,6 +15,7 @@ > > */ > > > > #include <linux/kernel.h> > > +#include <linux/dmi.h> > > #include <linux/i2c.h> > > #include <linux/input.h> > > #include <linux/input/mt.h> > > @@ -34,6 +35,7 @@ struct goodix_ts_data { > > int abs_y_max; > > unsigned int max_touch_num; > > unsigned int int_trigger_type; > > + bool rotated_screen; > > }; > > > > #define GOODIX_MAX_HEIGHT 4096 > > @@ -60,6 +62,24 @@ static const unsigned long goodix_irq_flags[] = > > { > > IRQ_TYPE_LEVEL_HIGH, > > }; > > > > +/* Those tablets have their coords origin at the bottom right > > + * of the tablet, as if rotated 180 degrees */ > > /* > * Multi > * line > * comment > */ > > please. Would be good if checkpatch could check for that, or is it a personal request? > > +static const struct dmi_system_id rotated_screen[] = { > > #if defined(CONFIG_DMI) && defined(CONFIG_X86) Sure. > > + { > > + .ident = "WinBook TW100", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "TW100") > > + }, > > + .ident = "WinBook TW700", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "TW100") > > + }, > > This does not do what you want it to do... First of all you probably > wanted TW700 on the second entry, second you need separate them into > 2 > entries into array (right now it is one still). Duh! Thanks, coming in v3 shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists