linux-kernel - Re: [PATCH] power_supply: Adjust devm usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK-LDbKzzNGvRs7GNi9vNT5wP+zV0PfJtWbg622h5vS4HYLThg@mail.gmail.com>
Date:	Fri, 24 Jul 2015 18:05:35 +0530
From:	Vaishali Thakkar <vthakkar1994@...il.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Frans Klaver <fransklaver@...il.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power_supply: Adjust devm usage

On Fri, Jul 24, 2015 at 5:59 PM, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:
> 2015-07-24 21:17 GMT+09:00 Frans Klaver <fransklaver@...il.com>:
>> Hi,

Hi

>> On Fri, Jul 24, 2015 at 1:58 PM, Vaishali Thakkar
>> <vthakkar1994@...il.com> wrote:
>>> Use devm_kasprintf instead of kasprintf. Also, remove various
>>> gotos by direct returns and drop unneeded label err_free_name.
>>
>> If there's to be a respin, reword this so that it becomes clearer that
>> removing the various gotos and the label is an effect of using
>> devm_kasprintf here. I started out thinking that this patch did two
>> things.

Ok. Sure. I will change the commit log.

> And please put a driver prefix in the subject (like in rest of
> commits). Beside of that:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Ok.

> Best regards,
> Krzysztof



-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/