[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABxcv=niSnKNL7+pdqQ_BaK6rdK5Myangq04ASr+SREoSCHEAA@mail.gmail.com>
Date: Fri, 24 Jul 2015 15:18:27 +0200
From: Javier Martinez Canillas <javier@...hile0.org>
To: Henry Chen <HenryC.Chen@...iatek.com>
Cc: Mark Brown <broonie@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Liam Girdwood <lgirdwood@...il.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
linux-mediatek@...ts.infradead.org,
Sascha Hauer <kernel@...gutronix.de>,
Matthias Brugger <matthias.bgg@...il.com>,
eddie.huang@...iatek.com,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for
mt6311 regulator
Hello Henry,
On Fri, Jul 24, 2015 at 2:59 PM, Henry Chen <HenryC.Chen@...iatek.com> wrote:
> Hi Javier,
>
> On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote:
>> Hello Henry,
>>
>> I believe Mark asked you to use a subject lines reflecting the style
>> for the subsystem, so the subject should had been something like:
>>
>> regulators: mt6311: Add DT binding document
>>
>> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@...iatek.com> wrote:
>> > This patch adds a list of supported regulator names to the devicetree
>> > binding documentation for Mediatek MT6311 PMIC.
>> >
>> > Signed-off-by: Henry Chen <henryc.chen@...iatek.com>
>> > ---
>>
>> I know is in your cover letter, but usually is good to also include a
>> history log of the changes for each patch so people know what changed.
>> Everything between the '---' and the diff are omitted by tools like
>> git am so you can add there. You can use tools like patman that do
>> this automatically for you.
>>
> Ok, got it, I will follow that.
>
>> Also, I said that you could add my Reviewed-by after the node name
>> change so you should had carried that. So again:
>
> Sorry, did you mean I need to resent again?
>
Sorry for not being clear. No, it's not necessary to resend. I just
mentioned for the next time.
> Thanks for advise.
> Henry
>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists