linux-kernel - Re: [PATCH v2] thermal: consistently use int for temperatures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B244BE.1060203@roeck-us.net>
Date:	Fri, 24 Jul 2015 06:59:26 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Sascha Hauer <s.hauer@...gutronix.de>, Pavel Machek <pavel@....cz>
CC:	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-kernel@...r.kernel.org,
	Punit Agrawal <punit.agrawal@....com>,
	Jean Delvare <jdelvare@...e.de>,
	Peter Feuerer <peter@...e.net>,
	Heiko Stuebner <heiko@...ech.de>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Darren Hart <dvhart@...radead.org>, lm-sensors@...sensors.org
Subject: Re: [PATCH v2] thermal: consistently use int for temperatures

On 07/23/2015 11:29 PM, Sascha Hauer wrote:
> On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote:
>> On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
>>> The thermal code uses int, long and unsigned long for temperatures
>>> in different places.
>>>
>>> Using an unsigned type limits the thermal framework to positive
>>> temperatures without need. Also several drivers currently will report
>>> temperatures near UINT_MAX for temperatures below 0°C. This will probably
>>> immediately shut the machine down due to overtemperature if started below
>>> 0°C.
>>>
>>> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
>>> is above the melting point of all known materials.
>>
>> Can we do something like
>>
>> typedef millicelsius_t int;
>>
>> ...to document the units?
>
> I am not very fond of typedefs and I am not sure this adds any value. I
> could change it when more people ask for it, but I just sent the new
> version without this.
>

I thought we are supposed to not introduce new typedefs anyway.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/