linux-kernel - Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150724144651.GE27569@earth>
Date:	Fri, 24 Jul 2015 16:46:51 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Ramakrishna Pallala <ramakrishna.pallala@...el.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_*
 properties support

Hi,

On Tue, Jun 23, 2015 at 09:58:41AM +0900, Krzysztof Kozlowski wrote:
> 2015-06-08 10:22 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@...sung.com>:
> > 2015-05-24 12:41 GMT+09:00 Ramakrishna Pallala <ramakrishna.pallala@...el.com>:
> >> This patch adds the support for following battery properties
> >> to max17042 fuel gauge driver.
> >>
> >> POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> >> POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> >> POWER_SUPPLY_PROP_TEMP_MIN
> >> POWER_SUPPLY_PROP_TEMP_MAX
> >> POWER_SUPPLY_PROP_HEALTH
> >
> > I wonder, have you tested the patch? After booting on Trats2 device
> > (max77693 which identifies itself as 17047-like) the values are:
> > POWER_SUPPLY_TEMP_ALERT_MIN=1280
> > POWER_SUPPLY_TEMP_ALERT_MAX=1270
> > POWER_SUPPLY_TEMP=257
> > This is okay, datasheet says that register after booting will have
> > value of 0x7f80.
> >
> > However setting them to some value which should trigger interrupts
> > (like 300 for MIN or 200 for MAX) does not trigger the interrupt. I
> > added a printk in max17042_thread_handler().
> >
> > Is the temperature alert feature working?
> 
> Can you reply to my question above?
> If this feature is not working, then it should be removed.

What's the status of this? I cannot test the feature, since
I don't have the hardware. I agree, that this should be
removed, if it's not working.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)