linux-kernel - Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B2743F.6060304@synopsys.com>
Date:	Fri, 24 Jul 2015 20:22:07 +0300
From:	Vineet Gupta <vgupta@...opsys.com>
To:	Kalle Valo <kvalo@...eaurora.org>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	Pieter-Paul Giesberts <pieterpg@...adcom.com>,
	Daniel Kim <dekim@...adcom.com>,
	linux-wireless@...r.kernel.org, brcm80211-dev-list@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

On Friday 24 July 2015 08:02 PM, Kalle Valo wrote:
> Vineet Gupta <Vineet.Gupta1@...opsys.com> writes:
> 
>> > There's already a generic implementation so use that instead.
>> > ---
>> > I'm not sure if the driver usage of atomic_or?() is correct in terms of
>> > storage size of @val for 64 bit arches.
>> >
>> > Assuming LP64 programming model for linux on say x86_64: atomic_or()
>> > callers in this driver use long (sana 64 bit) storage and pass it to
>> > atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ?
>> > ---
>> > Cc: Brett Rudley <brudley@...adcom.com>
>> > Cc: Arend van Spriel <arend@...adcom.com>
>> > Cc: "Franky (Zhenhui) Lin" <frankyl@...adcom.com>
>> > Cc: Hante Meuleman <meuleman@...adcom.com>
>> > Cc: Kalle Valo <kvalo@...eaurora.org>
>> > Cc: Pieter-Paul Giesberts <pieterpg@...adcom.com>
>> > Cc: Daniel Kim <dekim@...adcom.com>
>> > Cc: linux-wireless@...r.kernel.org
>> > Cc: brcm80211-dev-list@...adcom.com
>> > Cc: Peter Zijlstra <peterz@...radead.org>
>> > Cc: Ingo Molnar <mingo@...nel.org>
>> > Cc: netdev@...r.kernel.org
>> > Cc: linux-arch@...r.kernel.org
>> > Cc: linux-kernel@...r.kernel.org
>> > Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
>> >
>> > Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
> What's the plan with this patch? Should I take it to my
> wireless-drivers-next tree or will someone else take it?


Per last discussion on this topic, Arend wanted to discuss abt this with Hante.
I'm not taking it anyways so feel free to pick it up if you want !

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/