linux-kernel - Re: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B2A0C1.4000906@ti.com>
Date:	Fri, 24 Jul 2015 15:32:01 -0500
From:	"Andrew F. Davis" <afd@...com>
To:	Joe Perches <joe@...ches.com>,
	Pali Rohár <pali.rohar@...il.com>
CC:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Dan Murphy <dmurphy@...com>, <linux-pm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking

On 07/23/2015 12:06 PM, Joe Perches wrote:
> On Thu, 2015-07-23 at 18:22 +0200, Pali Rohár wrote:
>> On Wednesday 22 July 2015 16:52:00 Andrew F. Davis wrote:
>>> Reorganize the logic checking battery health and under temperature
>>> condition checking.
> []
>>> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> []
>>> @@ -624,10 +626,34 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di)
>>>   */
>>>  static int bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags)
>>>  {
>>> -	if (di->chip == BQ27500 || di->chip == BQ27541)
>>> +	if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545)
>>>  		return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
>>> +	if (di->chip == BQ27530 || di->chip == BQ27421)
>>> +		return flags & BQ27XXX_FLAG_OT;
>>> +
>>> +	return false;
> 
> Maybe this int function should be bool or return 0
> instead of false.
> 
>>> +static int bq27xxx_battery_undertemp(struct bq27xxx_device_info *di, u16 flags)
>>> +{
>>> +	if (di->chip == BQ27530 || di->chip == BQ27421)
>>> +			return flags & BQ27XXX_FLAG_UT;
>>> +
>>> +	return false;
>>> +}
> 
> Here too
> 
>>> +
>>> +/*
>>> + * Returns true if a low state of charge condition is detected
>>> + */
>>> +static int bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
>>> +{
>>> +	if (di->chip == BQ27000 || di->chip == BQ27010)
>>> +		return flags & (BQ27000_FLAG_EDV1 | BQ27000_FLAG_EDVF);
>>>  	else
>>> -		return flags & BQ27XXX_FLAG_OTC;
>>> +		return flags & (BQ27XXX_FLAG_SOC1 | BQ27XXX_FLAG_SOCF);
>>>  }
> 
> and here
> 
> 

I think I'll change the return to bool as these functions are only used in an if
statement checking for true/false.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/