linux-kernel - Re: [RFC] arm64:use set_fixmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9E910A45-D4AB-44F6-878F-3CB2372B3660@gmail.com>
Date:	Fri, 24 Jul 2015 11:56:59 +0800
From:	yalin wang <yalin.wang2010@...il.com>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Will Deacon <will.deacon@....com>, zlim.lnx@...il.com,
	punit.agrawal@....com, marc.zyngier@....com, lauraa@...eaurora.org,
	wcohen@...hat.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] arm64:use set_fixmap_offset to make it more clear


> On Jul 23, 2015, at 21:03, Catalin Marinas <catalin.marinas@....com> wrote:
> 
> On Thu, Jul 23, 2015 at 07:45:53PM +0800, yalin wang wrote:
>> A little change to patch_map() function,
>> use set_fixmap_offset() to make code more clear.
>> 
>> Signed-off-by: yalin wang <yalin.wang2010@...il.com>
>> ---
>> arch/arm64/kernel/insn.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
>> index dd9671c..7dafd5a 100644
>> --- a/arch/arm64/kernel/insn.c
>> +++ b/arch/arm64/kernel/insn.c
>> @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap)
>> 		return addr;
>> 
>> 	BUG_ON(!page);
>> -	set_fixmap(fixmap, page_to_phys(page));
>> -
>> -	return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK));
>> +	return (void *)set_fixmap_offset(fixmap, page_to_phys(page) +
>> +			(addr & ~PAGE_MASK));
> 
> It looks fine. Do you get any compiler warning for the automatic pointer
> to long conversion? You may want to add some explicit casts, otherwise:
> 
> Acked-by: Catalin Marinas <catalin.marinas@....com>
i have build it, there is no warning about this change. :)
Thanks--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/