linux-kernel - [PATCH] parport: Revert "parport: fix memory leak"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 25 Jul 2015 13:19:40 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, Ying Huang <ying.huang@...el.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: [PATCH] parport: Revert "parport: fix memory leak"

This reverts commit 23c405912b88 ("parport: fix memory leak")

par_dev->state was already being removed in parport_unregister_device().

Reported-by: Ying Huang <ying.huang@...el.com>
Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
---

But I am surprised at two points:
1) Why the error came while loading the gs_fpgaboot module?
	Maybe the double freeing has freed some memory which fpga was
	using.
2) Why the dmesg showed "panel: could not claim access to parport0. Aborting."?
	Because of 50566ac87065 ("parport: check exclusive access before
	register") the panel driver should not even register and it
	should have failed at parport_register_dev_model().

 drivers/parport/share.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index c02b5f2..5ce5ef2 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -816,7 +816,6 @@ static void free_pardevice(struct device *dev)
 	struct pardevice *par_dev = to_pardevice(dev);
 
 	kfree(par_dev->name);
-	kfree(par_dev->state);
 	kfree(par_dev);
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/