| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150725033036.GI12927@tiger>
Date: Sat, 25 Jul 2015 11:30:36 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: Stefan Agner <stefan@...er.ch>
Cc: dwmw2@...radead.org, computersforpeace@...il.com,
mark.rutland@....com, boris.brezillon@...e-electrons.com,
aaron@...tycactus.com, marb@...at.de, pawel.moll@....com,
ijc+devicetree@...lion.org.uk, bpringlemeir@...il.com,
linux-kernel@...r.kernel.org, sebastian@...akpoint.cc,
robh+dt@...nel.org, linux-mtd@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
galak@...eaurora.org, shawn.guo@...aro.org,
devicetree@...r.kernel.org,
Bill Pringlemeir <bpringlemeir@...ps.com>
Subject: Re: [PATCH v7 4/5] ARM: dts: vf610twr: add NAND flash controller
peripherial
On Fri, Jul 24, 2015 at 03:16:23PM +0200, Stefan Agner wrote:
> This adds the NAND flash controller (NFC) peripherial. The driver
> supports the SLC NAND chips found on Freescale's Vybrid Tower System
> Module. The Micron NAND chip on the module needs 4-bit ECC per 512
> byte page. Use 24-bit ECC per 2k page, which is supported by the
> driver.
>
> Signed-off-by: Bill Pringlemeir <bpringlemeir@...ps.com>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> arch/arm/boot/dts/vf610-twr.dts | 44 +++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/vfxxx.dtsi | 8 ++++++++
> 2 files changed, 52 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index 375ab23..0b2b932 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -287,6 +287,50 @@
> status = "okay";
> };
>
> +&iomuxc {
> + vf610-twr {
> + pinctrl_nfc_1: nfcgrp_1 {
The suffix "_1" is meaningless. Please drop it here as well as patch
#5.
Shawn
> + fsl,pins = <
> + VF610_PAD_PTD31__NF_IO15 0x28df
> + VF610_PAD_PTD30__NF_IO14 0x28df
> + VF610_PAD_PTD29__NF_IO13 0x28df
> + VF610_PAD_PTD28__NF_IO12 0x28df
> + VF610_PAD_PTD27__NF_IO11 0x28df
> + VF610_PAD_PTD26__NF_IO10 0x28df
> + VF610_PAD_PTD25__NF_IO9 0x28df
> + VF610_PAD_PTD24__NF_IO8 0x28df
> + VF610_PAD_PTD23__NF_IO7 0x28df
> + VF610_PAD_PTD22__NF_IO6 0x28df
> + VF610_PAD_PTD21__NF_IO5 0x28df
> + VF610_PAD_PTD20__NF_IO4 0x28df
> + VF610_PAD_PTD19__NF_IO3 0x28df
> + VF610_PAD_PTD18__NF_IO2 0x28df
> + VF610_PAD_PTD17__NF_IO1 0x28df
> + VF610_PAD_PTD16__NF_IO0 0x28df
> + VF610_PAD_PTB24__NF_WE_B 0x28c2
> + VF610_PAD_PTB25__NF_CE0_B 0x28c2
> + VF610_PAD_PTB27__NF_RE_B 0x28c2
> + VF610_PAD_PTC26__NF_RB_B 0x283d
> + VF610_PAD_PTC27__NF_ALE 0x28c2
> + VF610_PAD_PTC28__NF_CLE 0x28c2
> + >;
> + };
> + };
> +};
> +
> +&nfc {
> + assigned-clocks = <&clks VF610_CLK_NFC>;
> + assigned-clock-rates = <33000000>;
> + nand-bus-width = <16>;
> + nand-ecc-mode = "hw";
> + nand-ecc-step-size = <2048>;
> + nand-ecc-strength = <24>;
> + nand-on-flash-bbt;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_nfc_1>;
> + status = "okay";
> +};
> +
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..2f4b04d 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -520,6 +520,14 @@
> status = "disabled";
> };
>
> + nfc: nand@...e0000 {
> + compatible = "fsl,vf610-nfc";
> + reg = <0x400e0000 0x4000>;
> + interrupts = <83 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_NFC>;
> + clock-names = "nfc";
> + status = "disabled";
> + };
> };
> };
> };
> --
> 2.4.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists