linux-kernel - Re: [PATCH] Staging:dgap :Compression of lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437939564.2669.96.camel@perches.com>
Date:	Sun, 26 Jul 2015 12:39:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:dgap :Compression of lines for immediate return

On Sun, 2015-07-26 at 23:04 +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as follows:
> 
> @@
> expression ret;
> identifier f;
> @@
> -ret =
> +return
>      f(...);
> -return ret;

This isn't an always safe or side-effect free
semantic patch as there may be a cast lost by
such a conversion.

int foo(void)
{
	char i = 0xffffffff;
	return i;
}

where i is now int not char

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/