linux-kernel - Re: [PATCH 1/8] misc: cxl: clean up afu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437951966.6262.3.camel@axtens.net>
Date:	Mon, 27 Jul 2015 09:06:06 +1000
From:	Daniel Axtens <dja@...ens.net>
To:	Vladimir Zapolskiy <vz@...ia.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Neuling <mikey@...ling.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Ian Munsie <imunsie@....ibm.com>
Subject: Re: [PATCH 1/8] misc: cxl: clean up afu_read_config()

Hi,

Reviewed-by: Daniel Axtens <dja@...ens.net>

FWIW, Ian is on leave for 2 weeks and Mikey for 1 week. However, as one
of the other CXL developers I'm very happy for this patch to go in.

Regards,
Daniel

On Mon, 2015-07-27 at 00:18 +0300, Vladimir Zapolskiy wrote:
> The sanity checks for overflow are not needed, because this is done on
> caller side in fs/sysfs/file.c
> 
> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: Ian Munsie <imunsie@....ibm.com>
> Cc: Michael Neuling <mikey@...ling.org>
> ---
>  drivers/misc/cxl/sysfs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
> index 31f38bc..87cd747 100644
> --- a/drivers/misc/cxl/sysfs.c
> +++ b/drivers/misc/cxl/sysfs.c
> @@ -443,12 +443,7 @@ static ssize_t afu_read_config(struct file *filp, struct kobject *kobj,
>  	struct afu_config_record *cr = to_cr(kobj);
>  	struct cxl_afu *afu = to_cxl_afu(container_of(kobj->parent, struct device, kobj));
>  
> -	u64 i, j, val, size = afu->crs_len;
> -
> -	if (off > size)
> -		return 0;
> -	if (off + count > size)
> -		count = size - off;
> +	u64 i, j, val;
>  
>  	for (i = 0; i < count;) {
>  		val = cxl_afu_cr_read64(afu, cr->cr, off & ~0x7);


Download attachment "signature.asc" of type "application/pgp-signature" (861 bytes)