linux-kernel - Re: [PATCH v3 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437878482.3040.6.camel@mhfsdcap03>
Date:	Sun, 26 Jul 2015 10:41:22 +0800
From:	chunfeng yun <chunfeng.yun@...iatek.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Mathias Nyman <mathias.nyman@...el.com>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	"Matthias Brugger" <matthias.bgg@...il.com>,
	Felipe Balbi <balbi@...com>,
	"Sascha Hauer" <s.hauer@...gutronix.de>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	"Roger Quadros" <rogerq@...com>, <linux-usb@...r.kernel.org>,
	<linux-mediatek@...ts.infradead.org>,
	John Crispin <blogic@...nwrt.org>,
	Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH v3 5/5] arm64: dts: mediatek: add xHCI & usb phy for
 mt8173

hi
On Wed, 2015-07-22 at 21:11 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 07/22/2015 05:05 PM, Chunfeng Yun wrote:
> 
> > add xHCI and phy drivers for MT8173-EVB
> 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 ++++++++++++++
> >   arch/arm64/boot/dts/mediatek/mt8173.dtsi    | 31 +++++++++++++++++++++++++++++
> >   2 files changed, 46 insertions(+)
> 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > index f433c21..202b2b9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > @@ -13,6 +13,7 @@
> >    */
> >
> >   /dts-v1/;
> > +#include <dt-bindings/gpio/gpio.h>
> >   #include "mt8173.dtsi"
> >
> >   / {
> > @@ -32,6 +33,15 @@
> >   	};
> >
> >   	chosen { };
> > +
> > +	usb_p1_vbus: fixedregulator@0 {
> 
>     Just "regulator@0" please. This is more in line with what ePAPR requires 
> from the node names.
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "usb_vbus";
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +		gpio = <&pio 130 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
> > +	};
> >   };
> >
> >   &pwrap {
> [...]
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 0696f8f..aa1ecc7 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> [...]
> > @@ -393,6 +394,36 @@
> >   			#size-cells = <0>;
> >   			status = "disabled";
> >   		};
> > +
> > +		usb: usb30@...70000 {
> 
>     ePAPR standardizes the name "usb" for such nodes, please fix.
> 
> [...]
> 
ok, I'll revise it, thanks a lot

> MBR, Sergei
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/