linux-kernel - Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150726163153.GF24646@krava.brq.redhat.com>
Date:	Sun, 26 Jul 2015 18:31:53 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	kan.liang@...el.com
Cc:	a.p.zijlstra@...llo.nl, acme@...nel.org, luto@...nel.org,
	mingo@...hat.com, eranian@...gle.com, ak@...ux.intel.com,
	mark.rutland@....com, adrian.hunter@...el.com, jolsa@...nel.org,
	namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct
 perf_sample

On Fri, Jul 24, 2015 at 09:48:30AM -0400, kan.liang@...el.com wrote:

SNIP

> +	u64 nr = 0;
>  
>  	if (sid) {
>  		sample->id     = v->id;
> @@ -1010,6 +1012,20 @@ static int deliver_sample_value(struct perf_evlist *evlist,
>  		return 0;
>  	}
>  
> +	if (perf_evsel__is_group_leader(sid->evsel)) {
> +		evsel = sid->evsel;
> +		SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> +				    sample->read.group.values[nr].value);
> +		evlist__for_each_continue(evlist, evsel) {
> +			if ((evsel->leader != sid->evsel) ||
> +			    (++nr >= sample->read.group.nr))
> +				break;
> +
> +			SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> +					    sample->read.group.values[nr].value);

I think this should be in upper layer.. why not do this also
within iter_prepare_normal_entry as for the rest of the calculations
I suggested in my other email

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/