linux-kernel - Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 26 Jul 2015 16:36:07 +0000
From:	"Joglekar, Tejas (T.)" <tjogleka@...teon.com>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
CC:	"Larry.Finger@...inger.net" <Larry.Finger@...inger.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related
 error

On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote:
> "Joglekar, Tejas (T.)" <tjogleka@...teon.com> writes:
> > From: Joglekar Tejas <tjogleka@...teon.com>
> >
> > This patch fixes the error given by checkpatch.pl
> >
> > Signed-off-by: Joglekar Tejas <tjogleka@...teon.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > index 29a29d9..48b7723 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
> >  			/* pairwise key */
> >  			rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
> >  			/* group key */
> > -			rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> > +			rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> >  		}
> >  	}
> >  }
> 
> NAK!
> 
> If you are 'fixing' checkpatch 'errors', do it properly and break down
> the line and solve the 80 character limit 'error' as well.
> 
> Jes

Jes ,
Sure, I will break down the line, and remove the 80 character limit issue , before resending the patch.

Thanks & Regards,
Tejas Joglekar--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/