linux-kernel - Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrWrcGOAZxpuau53n6oUdO5NwTb6GDFKM850RmhqDV1ezA@mail.gmail.com>
Date:	Sun, 26 Jul 2015 11:50:59 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brian Gerst <brgerst@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>, Willy Tarreau <w@....eu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

On Sat, Jul 25, 2015 at 11:05 PM, Borislav Petkov <bp@...en8.de> wrote:
> On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote:
>> This will allow IRQ stacks to nest inside NMIs or similar entries
>> that can happen during IRQ stack setup or teardown.
>>
>> The Xen code here has a confusing comment.
>>
>> The new macros won't work correctly if they're invoked with IRQs on.
>> Add a check under CONFIG_DEBUG_ENTRY to detect that.
>>
>> Signed-off-by: Andy Lutomirski <luto@...nel.org>
>> ---
>>  arch/x86/Kconfig.debug       |  2 -
>>  arch/x86/entry/entry_64.S    | 89 +++++++++++++++++++++++++++++---------------
>>  arch/x86/kernel/process_64.c |  4 ++
>>  3 files changed, 63 insertions(+), 32 deletions(-)
>
> What does that apply against?
>
> I get conflicts against current Linus master:

It applies to the result of merging Linus' master with tip/x86/asm.  I
think it also applies to tip/x86/asm directly, but I haven't tried it.
It's an NMI-related thing (sort of), so it seemed sensible to develop
against something that has the other NMI fixes.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/