linux-kernel - Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D1DC074A.14AD9%quinn.tran@qlogic.com>
Date:	Mon, 27 Jul 2015 23:25:30 +0000
From:	Quinn Tran <quinn.tran@...gic.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Dilip Uppugandla <dilip@...estorage.com>
CC:	Spencer Baugh <sbaugh@...ern.com>,
	Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...gic.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Joern Engel <joern@...estorage.com>,
	"Spencer Baugh" <Spencer.baugh@...estorage.com>,
	"target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
	Bart Van Assche <bart.vanassche@...disk.com>
Subject: Re: [PATCH] qla2xxx: Return the fabric command state for non-task
 management requests

Christoph,

Currently, the command state within TCM (se_cmd.t_state) only track
command states from the point of new to the Back End and from Back End up
to QLA driver.  From the debug perspective, that¹s only half the picture.
The other half comes from qla2xxx¹s private command state provided by this
patch.

Having another trace point that happens 5~10 seconds ago might be
difficult to back track.  For task management debugging, dumping the
current states (se_cmd + qla_tgt_cmd) of each command when the TMR is
received provides some benefit.

If you feel uncomfortable with the "driver defined binary", one
alternative would be to translate QLA¹s private command state into
se_cmd¹s new field.  This new file would be modify by the fabric layer
only.  This would limit any regression with existing se_cmd field
modification.

Regards,
Quinn Tran

On 7/24/15, 11:29 PM, "target-devel-owner@...r.kernel.org on behalf of
Christoph Hellwig" <target-devel-owner@...r.kernel.org on behalf of
hch@...radead.org> wrote:

>Which debug printk do you care about?  I'd much prefer having a trace
>point inside the driver which could even pretty print it instead of the
>hack where a driver defined binary value is printed by the core.
>--
>To unsubscribe from this list: send the line "unsubscribe target-devel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/