linux-kernel - Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55B58DCC.6080208@huawei.com>
Date:	Mon, 27 Jul 2015 09:47:56 +0800
From:	"long.wanglong" <long.wanglong@...wei.com>
To:	Rob Herring <robherring2@...il.com>
CC:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<peifeiyue@...wei.com>, <wanglong@...qinren.net>
Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn

On 2015/7/27 4:39, Rob Herring wrote:
> On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong@...wei.com> wrote:
>> On 2015/7/25 3:00, Rob Herring wrote:
>>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@...wei.com> wrote:
>>>> Update the last pr_warning callsite in drivers/of.
>>>
>>> That is obvious in the diff, but can you tell me why?
>>
>> Hi Rob,
>>
>> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
>> will produce WARNING:
>>
>>         WARNING: Prefer pr_warn(... to pr_warning(...
>>         #22: FILE: drivers/of/fdt.c:428:
>>         +               pr_warning("End of tree marker overwritten: %08x\n",
>>
>> So,we should convert pr_warning to pr_warn.
> 
> Okay, but don't explain to me. Explain this in the commit message.
> 
> Rob
> 
> 

OK, i will send another patch and explain this in the commit message.

Wang Long

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/