linux-kernel - Re: [PATCH v4 0/7] KASAN for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <55B5E814.2020507@samsung.com>
Date:	Mon, 27 Jul 2015 11:13:08 +0300
From:	Andrey Ryabinin <a.ryabinin@...sung.com>
To:	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	David Keitel <dkeitel@...eaurora.org>,
	Alexander Potapenko <glider@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dmitry Vyukov <dvyukov@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Alexey Klimov <klimov.linux@...il.com>
Subject: Re: [PATCH v4 0/7] KASAN for arm64

On 07/24/2015 07:41 PM, Andrey Ryabinin wrote:
>  - fix memleak in kasan_populate_zero_shadow:
>        Following code could leak memory when pgd_populate() is nop:
> 		void *p = early_alloc(PAGE_SIZE, NUMA_NO_NODE);
> 		pgd_populate(&init_mm, pgd, p);

It's not a leak actually, because this code is under if (pgd_none(*pgd)).
But gcc complains warns about unused variable p, so this has to be changed anyways.

> 	This was replaced by:
> 	     	 pgd_populate(&init_mm, pgd, early_alloc(PAGE_SIZE, NUMA_NO_NODE));


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/