linux-kernel - Re: [PATCH 3/4] cp210x: Store part number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437989357.32457.3.camel@suse.com>
Date:	Mon, 27 Jul 2015 11:29:17 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Petr Tesarik <PTesarik@...e.com>
Cc:	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	PetrTesarik <ptesarik@...e.cz>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:USB SERIAL SUBSYSTEM" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 3/4] cp210x: Store part number

On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote:
> I don't understand. While you're right that I copied this part from
> Sillicon Labs' driver without much thinking, and &spriv->bPartNumber
> can be used directly, I can't see any DMA on stack. FWIW
> cp210x_control_msg always allocates a buffer using kcalloc:
> 
>         buf = kcalloc(length, sizeof(__le32), GFP_KERNEL);
> /* ... */
>         result = usb_control_msg(serial->dev,
> usb_rcvctrlpipe(serial->dev, 0),
>                                  request, requesttype, value,
>                                  spriv->bInterfaceNumber, buf, size,
> timeout);
> 
> Is that what you mean?

Yes, sorry, that part wasn't so clear from the previous patch.

	Sorry
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/