linux-kernel - Re: Revised futex(2) man page for review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B611B9.9030708@gmail.com>
Date:	Mon, 27 Jul 2015 13:10:49 +0200
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	Pavel Machek <pavel@....cz>, Peter Zijlstra <peterz@...radead.org>
CC:	mtk.manpages@...il.com, Thomas Gleixner <tglx@...utronix.de>,
	Darren Hart <dvhart@...ux.intel.com>,
	Carlos O'Donell <carlos@...hat.com>,
	Ingo Molnar <mingo@...e.hu>, Jakub Jelinek <jakub@...hat.com>,
	"linux-man@...r.kernel.org" <linux-man@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Davidlohr Bueso <dave@...olabs.net>,
	Arnd Bergmann <arnd@...db.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Linux API <linux-api@...r.kernel.org>,
	Torvald Riegel <triegel@...hat.com>,
	Roland McGrath <roland@...k.frob.com>,
	Darren Hart <dvhart@...radead.org>,
	Anton Blanchard <anton@...ba.org>,
	Eric Dumazet <edumazet@...gle.com>,
	bill o gallmeister <bgallmeister@...il.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Daniel Wagner <wagi@...om.org>, Rich Felker <dalias@...c.org>,
	Andy Lutomirski <luto@...capital.net>,
	bert hubert <bert.hubert@...herlabs.nl>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Heinrich Schuchardt <xypron.glpk@....de>
Subject: Re: Revised futex(2) man page for review

Hello Pavel,

On 04/27/2015 10:37 PM, Pavel Machek wrote:
> Hi!
> 
>>               The FUTEX_WAIT_OP operation is equivalent to execute the follow???
>>               ing  code  atomically  and totally ordered with respect to other
>>               futex operations on any of the two supplied futex words:
> 
> "to executing"?

Yep. Fixed.

>>               The  operation  and  comparison  that  are  to  be performed are
>>               encoded in the bits of  the  argument  val3.   Pictorially,  the
>>               encoding is:
>>
>>                       +---+---+-----------+-----------+
>>                       |op |cmp|   oparg   |  cmparg   |
>>                       +---+---+-----------+-----------+
>>                         4   4       12          12    <== # of bits
>>
> 
> :-)
> 
>> RETURN VALUE
>>        In the event of an error, all operations return -1  and  set  errno  to
>>        indicate  the  cause of the error.  The return value on success depends
>>        on the operation, as described in the following list:
> 
> Did you say (at the begining) that there is no glibc wrapper?

Yes, this could be clearer. I changed it to

RETURN VALUE
       In the event of an error (and assuming that futex()  was  invoked
       via  syscall(2)), all operations return -1 and set errno to indi‐
       cate the cause of the error.

>>        EINVAL The operation in futex_op is one of those that employs  a  time???
>>               out,  but  the supplied timeout argument was invalid (tv_sec was
>>               less than zero, or tv_nsec was not less than 1000,000,000).
> 
> 1,000...?

Fixed.

Thanks for the comments!

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/