linux-kernel - Re: dm cache: fix alloc_bitset check that always evaluates as false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2015 08:15:29 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Alasdair Kergon <agk@...hat.com>, dm-devel@...hat.com,
	Neil Brown <neilb@...e.com>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: dm cache: fix alloc_bitset check that always evaluates as false

On Thu, Jul 23 2015 at 11:47P -0400,
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> static analysis by cppcheck has found a check on alloc_bitset that
> always evaluates as false and hence never finds an allocation failure:
> 
> [drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction
>   always evaluates to false: !EXPR && EXPR.
> 
> Fix this by removing the incorrect mq->cache_hit_bits check
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied for 4.2-rc5 inclussion, thanks:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/