linux-kernel - Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150727134453.GA16064@redhat.com>
Date:	Mon, 27 Jul 2015 09:44:53 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Minfei Huang <mhuang@...hat.com>
Cc:	ebiederm@...ssion.com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Minfei Huang <mnfhuang@...il.com>
Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to
 simplify the code logic

On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@...il.com>
> 
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>

Looks good to me.

Acked-by: Vivek Goyal <vgoyal@...hat.com>

Thanks
Vivek

> ---
>  kernel/kexec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7a36fdc..4589899 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>  		/* If I don't overlap any segments I have found my hole! */
>  		if (i == image->nr_segments) {
>  			pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> +			image->control_page = hole_end;
>  			break;
>  		}
>  	}
> -	if (pages)
> -		image->control_page = hole_end;
>  
>  	return pages;
>  }
> -- 
> 2.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/