linux-kernel - Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150727140622.GB12993@earth>
Date:	Mon, 27 Jul 2015 16:06:22 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"Cavin, Courtney" <Courtney.Cavin@...ymobile.com>
Subject: Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

Hi,

On Sat, Jul 25, 2015 at 06:04:14PM -0700, Bjorn Andersson wrote:
> On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote:
> >  * battery-charge-control-limit
> > 
> > It's unclear, what this property is used for. Is the limit only
> > for "normal" charging or also for fast charging?
> > 
> 
> This is described as the current limit during fast charging. However,
> "fast charging" is the normal state.
> 
> I think the most consistent (regards documentation and other properties)
> would be:
> 
>  qcom,fast-charge-current-limit

So what's the difference to "fast-charge-safe-current"?

> >  * minimum-input-voltage
> > 
> > Add a vendor prefix to this property.
> > 
> 
> Shouldn't they all have a vendor prefix?

Some of the properties are quite generic and used on multiple
chips, so we may create a power_supply/battery-fuel-gauge.txt
and power_supply/battery-charger.txt with generic bindings.

I'm fine with just adding vendor prefixed properties for all
instances, though.

> Thanks for the review, I'll update the patches accordingly and
> will send out v2 (and make sure you get the dt binding document
> as well).

OK, thanks.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)