lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55B63CB0.7000302@roeck-us.net>
Date:	Mon, 27 Jul 2015 07:14:08 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Matt Fleming <matt@...eblueprint.co.uk>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH 5/5] i2c-i801: fixup regarding watchdog timer

On 07/27/2015 06:38 AM, Matt Fleming wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Change &array[0] to array since it's the same.
>
> It fixes 80 character limit warning as well.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Signed-off-by: Matt Fleming <matt.fleming@...el.com>

Should be merged into patch 2.

Guenter

> ---
>   drivers/i2c/busses/i2c-i801.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index c79dbe116ccc..e41005927746 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1173,7 +1173,8 @@ static void i801_add_tco(struct i801_priv *priv)
>   	if (!(tco_ctl & TCOCTL_EN))
>   		return;
>
> -	memset(&tco_res[0], 0, sizeof(tco_res));
> +	memset(tco_res, 0, sizeof(tco_res));
> +
>   	res = &tco_res[ICH_RES_IO_TCO];
>   	res->start = tco_base & ~1;
>   	res->end = res->start + 32 - 1;
> @@ -1226,7 +1227,7 @@ static void i801_add_tco(struct i801_priv *priv)
>   	res->flags = IORESOURCE_MEM;
>
>   	pdev = platform_device_register_resndata(&pci_dev->dev, "iTCO_wdt", -1,
> -						 &tco_res[0], 3, &tco_platform_data,
> +						 tco_res, 3, &tco_platform_data,
>   						 sizeof(tco_platform_data));
>   	if (IS_ERR(pdev)) {
>   		dev_warn(&pci_dev->dev, "failed to create iTCO device\n");
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ