linux-kernel - [PATCH -next] mm: Fix build breakage seen if MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1438009343-25468-1-git-send-email-linux@roeck-us.net>
Date:	Mon, 27 Jul 2015 08:02:23 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Andres Lagar-Cavilla <andreslc@...gle.com>,
	Vladimir Davydov <vdavydov@...allels.com>
Subject: [PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

Commit 65525488fa86 ("proc: add kpageidle file") introduces code
which depends on MMU_NOTIFIER, yet the newly introduced configuration
flag does not declare that dependency. This results in the following
build failures seen if IDLE_PAGE_TRACKING is configured but MMU_NOTIFIER
is not.

fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
fs/proc/page.c:341:4: error:
	implicit declaration of function 'pmdp_clear_young_notify'
fs/proc/page.c:347:4: error:
	implicit declaration of function 'ptep_clear_young_notify'

Fixes: 65525488fa86 ("proc: add kpageidle file")
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andres Lagar-Cavilla <andreslc@...gle.com>
Cc: Vladimir Davydov <vdavydov@...allels.com>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
 mm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 7e9ccb438985..b73b41c3217b 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -651,6 +651,7 @@ config DEFERRED_STRUCT_PAGE_INIT
 
 config IDLE_PAGE_TRACKING
 	bool "Enable idle page tracking"
+	depends on MMU_NOTIFIER
 	select PROC_PAGE_MONITOR
 	select PAGE_EXTENSION if !64BIT
 	help
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/