linux-kernel - Re: [PATCH v2 12/13] xtensa: implement fake NMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2015 17:14:37 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Max Filippov <jcmvbkbc@...il.com>
Cc:	linux-xtensa@...ux-xtensa.org, linux-kernel@...r.kernel.org,
	Chris Zankel <chris@...kel.net>,
	Marc Gauthier <marc@...ence.com>
Subject: Re: [PATCH v2 12/13] xtensa: implement fake NMI

On Sat, Jul 18, 2015 at 11:30:15AM +0300, Max Filippov wrote:
> In case perf IRQ is the highest of the medium-level IRQs, and is alone
> on its level, it may be treated as NMI:
> - LOCKLEVEL is defined to be one level less than EXCM level,
> - IRQ masking never lowers current IRQ level,
> - new fake exception cause code, EXCCAUSE_MAPPED_NMI is assigned to that
>   IRQ; new second level exception handler, do_nmi, assigned to it
>   handles it as NMI,
> - atomic operations in configurations without s32c1i still need to mask
>   all interrupts.
> 
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
> ---
>  arch/xtensa/include/asm/atomic.h    | 10 ++--
>  arch/xtensa/include/asm/cmpxchg.h   |  4 +-
>  arch/xtensa/include/asm/irqflags.h  | 22 ++++++++-
>  arch/xtensa/include/asm/processor.h | 31 ++++++++++++-
>  arch/xtensa/kernel/entry.S          | 93 +++++++++++++++++++++++++++++++------
>  arch/xtensa/kernel/irq.c            |  8 ++++
>  arch/xtensa/kernel/perf_event.c     |  6 ++-
>  arch/xtensa/kernel/traps.c          | 26 +++++++++++
>  arch/xtensa/kernel/vectors.S        | 10 +++-
>  9 files changed, 183 insertions(+), 27 deletions(-)

Looks about right, I've not really gone over the asm bits through.

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/