linux-kernel - Re: [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150727160447.GL1577@lahna.fi.intel.com>
Date:	Mon, 27 Jul 2015 19:04:47 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	mturquette@...libre.com, sboyd@...eaurora.org
Subject: Re: [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT

On Mon, Jul 27, 2015 at 04:27:33PM +0100, Lee Jones wrote:
> FAO Stephen Boyd,
> 
> > Stephen, can you, please, have a look into patch 8 regarding to clock name
> > matching and other stuff Lee asked?
> 
> Patch 8:
> 
>       "Can you review the clock implementation please?  It looks
>       fragile to me as it relies heavily on device names constructed
>       of MFD cell names and IDA numbers cat'ed together!"

Lee, can you suggest an alternative then?

Why we are doing it like this is that number of different LPSS devices
changes from SoC to SoC. In addition to that the device (called "slice")
might have iDMA block or not.

Since the drivers in question (pxa2xx-spi, i2c-designware and 8250_dw)
use standard clk framework to request their clocks the Linux device must
have clock registered which matches the device in advance.

Because we add the host controller device dynamically (from the MFD
driver) based on how many devices are actually present, we need somehow
predict what would be the correct name and instance number for that
device to get the clock for it. That's the reason we use IDA here along
with the cell name (or driver name).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/